fix: wrap debug pairing point checks in try-catch to fix nightly debug build#22040
Draft
AztecBot wants to merge 1 commit into
Draft
fix: wrap debug pairing point checks in try-catch to fix nightly debug build#22040AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
…g build The debug-only (#ifndef NDEBUG) native pairing point validation in PairingPoints constructor and aggregate() throws when witness values are zero-initialized (e.g. during VK generation with dummy data). The native PairingPoints constructor calls reduced_ate_pairing_batch_precomputed which aborts on off-curve points. In release builds this check is compiled out entirely. Wraps the debug checks in try-catch so they log the failure as info instead of crashing the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the nightly barretenberg debug build failure (
ChonkRecursionConstraintTest.GenerateRecursiveChonkVerifierVKFromConstraints).The debug-only
#ifndef NDEBUGnative pairing point validation inPairingPointsconstructor andaggregate()throws when witness values are zero-initialized (e.g. during VK generation with dummy data). The nativePairingPointsconstructor callsreduced_ate_pairing_batch_precomputedwhich aborts on off-curve points. In release builds this check is compiled out entirely.Wraps the debug checks in try-catch so they log the failure as info instead of crashing.
Verification
ChonkRecursionConstraintTest.GenerateRecursiveChonkVerifierVKFromConstraints— was FAILING, now PASSESbbapi_testspassChonkTests.BasicpassesAnalysis
https://gist.github.com/AztecBot/f4f7ddc58497acd348686b2d0e0edbe0
ClaudeBox log: https://claudebox.work/s/58cb1de59e0f55f9?run=1
ClaudeBox log: https://claudebox.work/s/58cb1de59e0f55f9?run=1